Fix search bar input on focus 1px shift #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `.search-input` set of styles defined `border: none`, while its `:focus` state has 1px border set. This led to the "micro-jump" of the placeholder text when the input field gets user focus (and it "jumps" back when it loses one). With this simple fix we always have invisible 1px border set to the input, so it prevents "jumping".
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
.search-inputset of styles definedborder: none, while its:focusstate has 1px border set. This led to the “micro-jump” of the placeholder text when the input field gets user focus (and it “jumps” back when it loses one).With this simple fix, we always have an invisible 1px border set to the input, so it prevents “jumping”.
Screen Recordings
before_ex_doc_search.mov
after_ex_doc_search.mov