Sort function names alphabetically in the sidebar #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExDoc.FunctionNode's :id is composed of the function name, a slash, and the function arity. For example: name/0. ExDoc.ModuleNode is sorting the functions alphabetically based on that :id, but it doesn't take into account that "/" >= "!" == true. That means that "fetch!/2" is displayed before "fetch/2".
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExDoc.FunctionNode's:idis composed of the function name, a slash, and the function arity. For example:name/0.ExDoc.ModuleNodeis sorting the functions alphabetically based on that:id, but it doesn't take into account that"/" >= "!" == true. That means thatfetch!/2is displayed beforefetch/2.This is a regression from previous docs (check order of
fetchandfetch!): Elixir v1.6Map, Elixir v1.7.3Map