Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intellisense, CamelCase filtering doesn't seem to work in version 0.5.0 and greater #150

Closed
ddaugher opened this issue Nov 7, 2020 · 2 comments

Comments

@ddaugher
Copy link

ddaugher commented Nov 7, 2020

typing 'ccc' in the Intellisense window, I would expect a value in the list with CustomerContactsController to be selected... two issues, the case of the input is not honored and the text input has to be exactly as the value in the list... e.g. typing 'CustomerC' will highlight the previously mentioned option.

The functionality works as I would expect in 0.4.0, but versions 0.5.0 and greater do not support this expectation. Was this changed by design... I would expect it to do CamelCase filtering as that is the standard for VSCode Intellisense.

I have attached images showing the issue.

The following image shows the list available after activating intellisense (version 0.6.1 of ElixirLS)

Screen Shot 2020-11-06 at 8 05 09 PM

This image shows after typing '.ccc'... everything is removed from list (version 0.6.1 of ElixirLS)

Screen Shot 2020-11-06 at 8 05 27 PM

This image shows what I expect to happen (version 0.4.0 of ElixirLS)
Screen Shot 2020-11-06 at 8 08 02 PM

@axelson
Copy link
Member

axelson commented Nov 8, 2020

ElixirLS never truly supported camel case filtering. I believe this is what was happening previously:

  • You type .: ElixirLS returns the list of modules in the first screenshot
  • You type c: I think ElixirLS then returns only the modules that start with c
  • You type ccc: ElixirLS returns an empty list and VSCode does client-side filtering

The ElixirLS behavior was changed in elixir-lsp/elixir-ls#259 to reduce the number of false-positive completions, in particular for do:
82835207-10d99c80-9e5f-11ea-82b1-b745707ecf74

If you have suggestions for different behavior that will solve that issue and still solve the issue you present here then we can look at making that change. Possibly we could add a configuration option to control isComplete but we'd have to look at the utility of that.

@ddaugher
Copy link
Author

thank you for the explanation... I will put some thought into how I would prefer this to work. I can work around it for now, but it was a nice side effect that I got used to. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants