Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase of compile-connected through xref #1086

Closed
raphaklaus opened this issue Apr 12, 2022 · 1 comment
Closed

Increase of compile-connected through xref #1086

raphaklaus opened this issue Apr 12, 2022 · 1 comment

Comments

@raphaklaus
Copy link

Hello!

I noticed that after upgrading from 1.13.4 to 1.13.5 it shows an extra compile-connected dependency:

lib/plug_compile_connected_issue_web/endpoint.ex
└── lib/plug_compile_connected_issue_web/router.ex (compile)

Demo repo (created with phx.new): https://github.com/raphaklaus/plug_compile_connected_issue

The master branch is pointing to version 1.13.4, which doesn't happen when running mix xref graph --label compile-connected

The branch named 1.13.5 shows the reported above.

This commit 04ac60a seems to talk about an init_mode that can be set to :compile or :runtime, but I am not sure if using that (if I used correctly) will fix the issue.

@josevalim
Copy link
Member

Fixed on v1.13.6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants