Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF Plug #137

Closed
gjaldon opened this issue Dec 5, 2014 · 0 comments · Fixed by #136
Closed

CSRF Plug #137

gjaldon opened this issue Dec 5, 2014 · 0 comments · Fixed by #136

Comments

@gjaldon
Copy link
Contributor

gjaldon commented Dec 5, 2014

From josevalim here phoenixframework/phoenix#338:

Two more notes:

It would be nice if we have a mechanism to skip the CSRF token if something is set inside the conn.private. For that, we could check if conn.private[:plug_skip_csrf_protection] is set to true and skip it. This would be useful for testing.

We should also add protection to this style of cross requests: rails/rails@1650bb3

Feel free to ping me if you need more info!

Currently WIP here: #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant