Fix TWCCRecorder base timestamp evaluation bug
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect I experienced this locally during multiple subsequent runs of |
|
@clone1018 most likely, I didn't recompile the module for some time (I guess the baked-in base timestamp value was somehow valid?). I noticed the issue when updating the Elixir version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TWCCRecordermodule has a default argument that keeps the initial value ofSystem.monotonic_time()(so the subsequent calls could be offset to be positive, as output ofSystem.monotonic_time()is usually negative). The value is evaluated at the compile time and differs from the runtime baseSystem.monotonic_time()value, which is obviously undesired. This PR fixes this issue.