Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker.Internet still generating content with unsafe characters #211

Closed
jc00ke opened this issue Oct 26, 2018 · 0 comments
Closed

Faker.Internet still generating content with unsafe characters #211

jc00ke opened this issue Oct 26, 2018 · 0 comments

Comments

@jc00ke
Copy link
Contributor

jc00ke commented Oct 26, 2018

I don't think the ~s('") actually removes ' characters ef4b56f#diff-e3ecc989170f877abe39eb1cdf76c35bR340

"foo@b'ar.com" |> String.replace(~s('"), "")
# "foo@b'ar.com"
"foo@b'ar.com" |> String.replace(~s("), "") |> String.replace(~s('), "")
# "foo@bar.com"

faker-single-quote
I'm still seeing this on b964ad1

PR in the works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jc00ke