Fixed: Quotes removal in Faker.Internet functions

[jc00ke]

Moved the implementation to Faker.Util.

Fixes #211

I've added:

• CHANGELOG.md

[jc00ke]

Hi! Anything else I can add here for this?

[igas]

Hi @jc00ke

I still think it's too specific to move to Util, I would keep it private in Internet module. I'm not sure what to suggest to test it properly. In ideal world we could test it through other public function, but we don't have one where we do not randomize it.

[jc00ke]

Yeah, I can't think of another good way to test it since the functions that use it don't take any input. About the only thing I can think of would be to make a test locale that had a single option for Name.first_name() et al with quotes in them. If not that, then I can stick it back in Internet, make it private and keep an eye out for regressions.

[igas]

Hi @jc00ke,

I pushed a fixed test to master and updated your branch. Please take a look and tell me what you think.

Thanks.

[jc00ke]

Looks good to me. I'll keep an eye out for issues in my own test suite. I know I've seen failures lately because of ' characters but I'm pretty sure it's not from the Internet module.