Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mox Lesson + Testing Lesson Updates #2343

Merged
merged 14 commits into from
Jul 15, 2020

Conversation

SophieDeBenedetto
Copy link
Contributor

This PR is opened in favor of this one from @fireproofsocks. It:

  • Moves @fireproofsocks' new content on Mox to its own lesson under libraries/
  • Update existing "mocking" section of Testing lesson to clarify and link to Mox lesson

@SophieDeBenedetto SophieDeBenedetto requested a review from a team as a code owner July 15, 2020 11:13
@SophieDeBenedetto SophieDeBenedetto added the new lesson An completely new lesson (not a translation) label Jul 15, 2020
Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small styleguide change and this is good to go! Thank you @SophieDeBenedetto and @fireproofsocks

en/lessons/libraries/mox.md Outdated Show resolved Hide resolved
en/lessons/libraries/mox.md Outdated Show resolved Hide resolved
@doomspork doomspork self-requested a review July 15, 2020 18:09
@doomspork
Copy link
Member

@fireproofsocks do you have a twitter handle? I'd love to give you a shoutout when we announce this new lesson you've put together.

@doomspork doomspork merged commit 9045a0a into elixirschool:master Jul 15, 2020
@fireproofsocks
Copy link

Thanks @doomspork ... although I have the @fireproofsocks handle on Twitter, I rarely use it. I also have https://medium.com/@fireproofsocks but most of the articles I write are paid contributions elsewhere, so there's not much to look at there, but I guess it wouldn't hurt to reference them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new lesson An completely new lesson (not a translation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants