Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation 1 #428

Merged
merged 4 commits into from
Jun 6, 2016

Conversation

HirofumiTamori
Copy link
Contributor

Translated Strings session into Japanese.

Opinion

This time, I just translated as same as the original, however I think multibyte character languages including Japanese should have additional description / examples / notes for the native users.
For example (Japanese small kana):

iex> string = "\uFF76\uFF9E"
"ガ"
iex> String.codepoints string
["カ", "゙"]
iex> String.graphemes string
["ガ"]
iex> String.length string
1

(note: I suspect that there is still no de facto standard of Japanese small kana's graphemes/codepoints translations, but Elixir just do it in this way)

@doomspork
Copy link
Member

Thank you @HirofumiTamori 👍

@3100 could you take a look at these changes?

@doomspork doomspork added the translation The translation of Elixir School content label May 31, 2016
@3100
Copy link
Contributor

3100 commented May 31, 2016

@HirofumiTamori I agree with your opinion. Please feel free to add some changes if you would like to apply them.

@3100 3100 merged commit 8a52c14 into elixirschool:master Jun 6, 2016
@3100
Copy link
Contributor

3100 commented Jun 6, 2016

Thank you, @HirofumiTamori!

@HirofumiTamori HirofumiTamori deleted the japanese_translation_1 branch June 9, 2016 16:10
@doomspork doomspork mentioned this pull request Jun 12, 2016
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation The translation of Elixir School content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants