Improve Responsiveness #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doomspork
added
enhancement
Updated the nav element to be a collapsable menu when the viewport is small (as in mobile, tablet, etc), so that users can still access all of the menu bar links from smaller screens.
doomspork
approved these changes
Jun 20, 2021
|
This is awesome to the max 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses #9 .
The primary focus of this pr is to update the header element to be more responsive. There are some other tweaks to page layouts to eliminate awkward gaps on smaller screens.
It turns out there were not many changes needed for the lessons menu!
I have added a few screenshots here taken from Chrome using the iPhone X viewport setting. I tested this with the iPad size and iPhone 5/SE screen size as well. Let me know if there are issues with specific device types/browsers that you can think of!
Also more generally if you think the layout of the menu should be different I am happy to make changes.
Screenshots