Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve posts translation logic #1211

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

alexzhang1030
Copy link
Member

@alexzhang1030 alexzhang1030 commented Jan 16, 2023

Description

closes #1118

  • move translate to end of contents
  • improve translation logic, improve error handling

Error cause I dont have this service. 😅

translate.mp4

Additional context

BTW, I don't know why I can't use onRequestError in nitro, It cannot reached.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Translations update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide related snapshots or videos.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@stackblitz
Copy link

stackblitz bot commented Jan 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 128723a
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c4fc15490c200009a120de

@alexzhang1030 alexzhang1030 changed the title feat: improve posts translation feat: improve posts translation logic Jan 16, 2023
@antfu antfu requested a review from danielroe January 16, 2023 09:24
@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 128723a
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c4fc156ab9d600080a98ec
😎 Deploy Preview https://deploy-preview-1211--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe merged commit d745bd0 into elk-zone:main Jan 16, 2023
@alexzhang1030 alexzhang1030 deleted the feat/issue-1118 branch January 16, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More appropriate placement of Translate button.
2 participants