Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support all HTML elements allowed by Glitch #1233

Merged
merged 1 commit into from
Jan 16, 2023
Merged

feat: support all HTML elements allowed by Glitch #1233

merged 1 commit into from
Jan 16, 2023

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Jan 16, 2023

Description

This pull request adds support for the rest of the HTML elements that glitch-soc allows. Some of the elements (like <em>) were already supported. This pull request fills up the roster with the rest of the elements based on https://github.com/glitch-soc/mastodon/blob/13227e1dafd308dfe1a3effc3379b766274809b3/lib/sanitize_ext/sanitize_config.rb.

The post pictured in issue #1230 looks like this after applying this change:

Screenshot 2023-01-16 at 19 33 37

Some elements, like <blockquote>, are now kept in the DOM, but their are essentially unstyled. This is probably best solved by someone who - unlike me - has a some styling skills 🙂

The test snapshot for one test needed to be updated, as <strong> elements are now allowed.

Closes #1230.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Translations update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide related snapshots or videos.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@stackblitz
Copy link

stackblitz bot commented Jan 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 750da83
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c58d7537473a0008d8d757

composables/content-parse.ts Outdated Show resolved Hide resolved
composables/content-parse.ts Outdated Show resolved Hide resolved
composables/content-parse.ts Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 750da83
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c58d75044bb40008113ebf
😎 Deploy Preview https://deploy-preview-1233--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit 8c17096 into elk-zone:main Jan 16, 2023
@jviide jviide deleted the glitch-tags branch January 16, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML from Mastodon is sanitized to plain text
4 participants