feat: StackBlitz code block expansion #1240
Conversation
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
LGTM. /cc @danielroe do you think we should add <Lazy to those components so they won't be included in the initial payload?
|
I would suggest to lower a bit the open text, it looks a bit too high |
|
@edimitchel I changed the order so it looks more like a card and integrated both with the rounded borders @antfu I think as we keep adding more of these card types, we should lazy load them. There may be a lot of users that won't need these components because their communities don't use GitHub, StackBlitz, or other domains that will add later. We could do that in another PR. I wonder if we should have a general On/Off switch for all the custom cards or individual ones. Leaning towards having only one to avoid too many options. |
Yes, we should. And probably also with the GitHub card too. 👍 |
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
|
Ok, I'm happy with this style for now, I think we can iterate and improve it in further PRs.
|
|
Yes iterate probably on limiting lines of code and let expand when needed. |
Description
StackBlitz added the code in the meta description when sharing a URL with
L1-L3(highlight code in a playground)https://stackblitz.com/edit/node?file=index.js%3AL1-L3
This would allow us to render the code using shiki instead of using a social image and have a snippet where you can click to see it working in a playground.
The design is still in progress, sending the PR to test and start playing
What is the purpose of this pull request?