Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): select first result on enter press #1289

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

baptiste0928
Copy link
Contributor

Description

Select the first search result when Enter is pressed, instead of closing the search results.

This is especially useful on mobile devices, since browsers (at least Firefox on Android) only emit text events when a non-letter key is pressed. Actually, using the Enter key will close the search results instead of performing the search.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Translations update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide related snapshots or videos.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@stackblitz
Copy link

stackblitz bot commented Jan 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 464d3e6
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c7d041bda5f100089007ff

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 464d3e6
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c7d0416393440008464f27
😎 Deploy Preview https://deploy-preview-1289--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit fb1f407 into elk-zone:main Jan 18, 2023
@baptiste0928 baptiste0928 deleted the baptiste0928/search-enter branch January 18, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants