Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Wrap field errors in a error span #11

Merged
merged 1 commit into from
Feb 19, 2014
Merged

Wrap field errors in a error span #11

merged 1 commit into from
Feb 19, 2014

Conversation

edds
Copy link
Contributor

@edds edds commented Feb 17, 2014

So that they can be styled differently to the label of the error box.

So that they can be styled differently to the label of the error box.
@elliotcm
Copy link
Owner

I'm down with the span being there but not if it means html_safeing a whole blob of interpolated variables.

I'll refactor it into some nested content_tags on Wednesday if you don't get there first.

@elliotcm
Copy link
Owner

OK keeping this stuff sensibly html_safe'd is going to be really ugly, so I'll add a warning not to send any user input into the labels, notes, and other options.

elliotcm added a commit that referenced this pull request Feb 19, 2014
Wrap field errors in a error span
@elliotcm elliotcm merged commit ac0f5ea into elliotcm:master Feb 19, 2014
@edds edds deleted the errors branch February 19, 2014 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants