/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Char.toCode` gives the same result for lowercase and uppercase letters #50

Closed
imeckler opened this Issue Dec 14, 2014 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@imeckler
@imeckler
Contributor

imeckler commented Dec 14, 2014

The offending line is line 20 of /src/Native/Char.js

toCode : function(c) { return c.toUpperCase().charCodeAt(0); },

@jonathanhefner jonathanhefner referenced this issue Jan 21, 2015

Merged

Remove incorrect upcase from Char.toCode (fix #50) #126

@evancz evancz closed this in 723aab7 Jan 22, 2015

evancz pushed a commit that referenced this issue Jan 22, 2015

@process-bot
Merge pull request #126 from jonathanhefner/issue-50-fix-char-tocode 
Remove incorrect upcase from Char.toCode (fix #50)
5d8a389

@kasbah kasbah referenced this issue Jan 23, 2015

Closed

KeyCode called "unicode" in Char documentation #82

kasbah added a commit to kasbah/elm-core that referenced this issue Jan 23, 2015

@jonathanhefner @kasbah
Remove incorrect upcase from Char.toCode (fix #50)
4fbdef7

kasbah added a commit to kasbah/elm-core that referenced this issue Jan 23, 2015

@jonathanhefner @kasbah
Remove incorrect upcase from Char.toCode (fix #50) 
Conflicts:
	tests/Test/Char.elm
995bc42

kasbah added a commit to kasbah/elm-core that referenced this issue Jan 23, 2015

@jonathanhefner @kasbah
Remove incorrect upcase from Char.toCode (fix #50)
4bf3128

@kasbah kasbah referenced this issue Feb 22, 2015

Closed

toCode and fromCode should be inverse operations #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment