Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When choosing PATH the video will not be saved in the choosen path unless it already exists. #20

Closed
JacoboGuijar opened this issue Jan 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@JacoboGuijar
Copy link

JacoboGuijar commented Jan 10, 2021

Describe the bug
When selecting a path where the video will be downloaded to it saves it in the parent folder if the selected folder does not exist.

To Reproduce

reddit = Downloader(max_q = True) 
reddit.log = False
reddit.path = 'C:\\Users\\MyUser\\Desktop\\bot\\NonExistentFolder\\'
reddit.url = 'https://www.reddit.com/r/pythonforengineers/comments/hfmo98/what_kind_of_hawk_is_this/'
reddit.download()

Expected behavior
The propper way to implement the path functionality should be to create a folder in case it does not exist.

Desktop:

  • OS: Windows 10

I know this is not super important but your library is super useful and I thought this might help with it.
Also, is there a way to change the file name or get it's name once it has been downloaded?

@elmoiv
Copy link
Owner

elmoiv commented Jan 12, 2021

Nice feature. I will be implementing it in the next update.

Yes you can get the file name by doing this:

file_name = reddit.download()

@elmoiv elmoiv added the enhancement New feature or request label Jan 12, 2021
@elmoiv
Copy link
Owner

elmoiv commented Mar 30, 2021

Added auto directory maker feature!

Just pip install redvid==1.1.3 to try it

@elmoiv elmoiv closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants