Allocate a new taskBatch for each batch of tasks in the WorkerManager #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#131 never releases the memory it allocates for taskBatches. Memory grows without bound, so processes using go_kafka_client will quickly run out of memory and die on HEAD right now.
Previously, we got around this by shrinking
currentBatch
- it was a map and we deleted entries. To avoid contention, we don't deleteEntries anymore, but we need to free up memory by dereferencing the taskBatch and allocating a new one.