Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content scripts are not injecting into some empty iframes #24

Open
Eloston opened this issue Oct 19, 2015 · 2 comments
Open

Content scripts are not injecting into some empty iframes #24

Eloston opened this issue Oct 19, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@Eloston
Copy link
Owner

Eloston commented Oct 19, 2015

The content scripts are not injecting into some empty iframes. This may be due to the current injection method since the content scripts are only injected when the onCommitted webNavigation event fires for http, https, and file protocols. Thus, this may be fixed with the switch back to manifest content scripts in #23.

An example of this is the Vidible media player when set to use iframes.
This is an example of the Vidible player autoplaying without the extension detecting any media: http://www.codingforums.com/javascript-programming/17254-javascript-documentation-references.html
This is relevant documentation on Vidible: https://vidible.atlassian.net/wiki/display/SUP/Player+Tag+API#PlayerTagAPI-Tags

@Eloston Eloston added the bug label Oct 19, 2015
@Eloston Eloston self-assigned this Oct 19, 2015
@Eloston Eloston added this to the 0.6 milestone Oct 19, 2015
@Eloston Eloston modified the milestones: 0.7, 0.6 Nov 9, 2015
@Eloston
Copy link
Owner Author

Eloston commented Dec 24, 2015

User Add Iran on the Chrome Web Store reported another website that has the same symptoms as this bug: http://www.chip.de/video/Die-besten-Weihnachts-Gadgets-Video_59235988.html

@Eloston
Copy link
Owner Author

Eloston commented Jan 25, 2016

User Mai Ling on the Chrome Web Store reported http://ro.yahoo.com, which exhibits the same bug. The problematic iframe has id html5_container, and the video has id video. The iframe and video appears near the top of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant