Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ALSA widget respect decorations #105

Closed
gibranlp opened this issue Sep 12, 2022 · 5 comments · Fixed by #107
Closed

Make ALSA widget respect decorations #105

gibranlp opened this issue Sep 12, 2022 · 5 comments · Fixed by #107
Assignees
@elParaguayo
Labels
decorations Something wrong with widget decorations enhancement New feature or request

Comments

@gibranlp
Copy link

When manipulating the volume, this does not respect the window decorations.
@elParaguayo
Copy link
Owner

elParaguayo commented Sep 13, 2022 •
edited
Loading

Thanks for the report. What do you mean by "does not respect" decorations? Screenshot would be ideal.

@gibranlp
Copy link
Author

0
10
40
100

@elParaguayo
Copy link
Owner

Ok. I understand. That's not possible at the moment as decorations are just a background layer that is drawn before the widget's contents. For the ALSA widget, the bar is just drawn on top and is not restricted by the decoration.

I have an idea that may work but, if not, this is not something that's easily fixable. I'll definitely look into it though as it would be a good effect.

@elParaguayo elParaguayo added enhancement New feature or request decorations Something wrong with widget decorations labels Sep 13, 2022
@elParaguayo elParaguayo self-assigned this Sep 13, 2022
elParaguayo added a commit that referenced this issue Sep 13, 2022
@elParaguayo
Add clipping to RectDecoration
e121141 
Fixes #105
@elParaguayo elParaguayo mentioned this issue Sep 13, 2022
Merged
@elParaguayo
Copy link
Owner

Think I've got this working in #107

elParaguayo added a commit that referenced this issue Sep 13, 2022
@elParaguayo
Add clipping to RectDecoration
8b54f09 
Fixes #105
@gibranlp
Copy link
Author

Awesome thanks man!

elParaguayo added a commit that referenced this issue Sep 14, 2022
@elParaguayo
Add clipping to RectDecoration
a89e5b8 
Fixes #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elParaguayo elParaguayo

Labels
decorations Something wrong with widget decorations enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clipping to RectDecoration elParaguayo/qtile-extras
2 participants
@elParaguayo @gibranlp