Issue #361 emergency details move #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramgarden
reviewed
Aug 29, 2017
crm/include/crm.inc.php
Outdated
| @@ -24,7 +24,7 @@ | |||
| $crm_version = array( | |||
| 'major' => 0 | |||
| , 'minor' => 4 | |||
| , 'patch' => 6 | |||
| , 'patch' => 7 | |||
There was a problem hiding this comment.
Would this be a big enough change to warrant moving up the minor version number by one?
There was a problem hiding this comment.
probably, yes, though @elplatt had previously mentioned that because the project was in maintenance only mode rather than active development, & it was a DB change, that he wasn't happy pushing this change
ramgarden
reviewed
Aug 29, 2017
crm/modules/member/command.inc.php
Outdated
|
|
||
| $member_data = crm_get_data('member', array('cid'=>$_POST['cid'])); | ||
| $member = $member_data[0]['member']; | ||
| $esc_cid = mysqli_real_escape_string($db_connect, $_POST['cid']); |
There was a problem hiding this comment.
Should this esc_cid get set up at the top of this scope then used throughout instead of $_POST['cid'] ??
There was a problem hiding this comment.
Probably! this code has been sitting around for over a year so I'd need to tweak & test it again!
ramgarden
reviewed
Aug 29, 2017
properly escape values elplatt#361
|
Fixed a bug that meant that escaping values wasn't working, cheers for the heads up :) |
check if a selected user has a specific permission
activate subresource integrity elplatt#390
properly escape values elplatt#361
…chris18890/seltzer into issue361_emergency_details_move
fixed it everwhere else as well
fix copyright year elplatt#363 elplatt#364 elplatt#378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves emergency details from contact module to member module, closes issue #361
redone PR #362 to factor in new pull requests