2nd bugfix for #361 - forgot about register module #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2nd bugfix for elplatt#361 - forgot about register module
|
@ramgarden @elplatt another one to check :) |
use existing member add form elplatt#361
ramgarden
reviewed
Sep 20, 2017
| @@ -27,12 +27,6 @@ | |||
| */ | |||
| function member_add_form () { | |||
|
|
|||
| // Ensure user is allowed to add members | |||
| if (!user_access('member_add')) { | |||
There was a problem hiding this comment.
this is to allow the form to be rendered without anyone being logged in, so it can be used as part of the register form
ramgarden
reviewed
Sep 20, 2017
| ) | ||
| ); | ||
| $form['fields'][] = array( | ||
| 'type' => 'fieldset', |
There was a problem hiding this comment.
You also removed all this membership info?
There was a problem hiding this comment.
Instead of trying to maintain 2 duplicate forms, I've set the register form to use the member_add form, as it's identical
|
@ramgarden @elplatt replied to the comments, are you happy for this to be merged? |
|
Yep. Satisfied my curiosity. Looks OK to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd bugfix for #361 - forgot about register module