Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in workload counter #94

Closed
1 task done
fako1024 opened this issue Apr 5, 2023 · 0 comments · Fixed by #100
Closed
1 task done

Race condition in workload counter #94

fako1024 opened this issue Apr 5, 2023 · 0 comments · Fixed by #100
Assignees
@fako1024
Labels
bug Something isn't working
Milestone
v4 Release

Comments

@fako1024
Copy link
Collaborator

fako1024 commented Apr 5, 2023 •
edited
Loading

The CI revealed a (minor) race condition in the workload counter of DBWorkManager (see run here).

DoD

  • Fix race condition (probably use an RWMutex or an atomic counter)
@fako1024 fako1024 added the bug Something isn't working label Apr 5, 2023
@fako1024 fako1024 added this to the v4 Release milestone Apr 5, 2023
@fako1024 fako1024 self-assigned this Apr 5, 2023
This was referenced Apr 5, 2023
Closed
Merged
@fako1024 fako1024 linked a pull request Apr 6, 2023 that will close this issue
Make DB workload counter atomic and align type with overall counter #100
Merged
@els0r els0r closed this as completed in #100 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fako1024 fako1024

Labels
bug Something isn't working
Projects
None yet
Milestone
v4 Release
Development

Successfully merging a pull request may close this issue.

Make DB workload counter atomic and align type with overall counter els0r/goProbe
1 participant
@fako1024