Activity Filter in API Not Filtering as Expected

[sfmskywalker]

We've encountered an issue where the ActivityFilter does not seem to be functioning as expected. Despite applying filters intended to yield no results under certain conditions, plans are being executed for instances that should ostensibly be filtered out.

Initial Conditions:

• There are two workflow instances.

Steps to Reproduce:

1. Create a plan with the following filter criteria:

   • hasIncidents: true (Expecting 2 instances to match this condition)
   • A filter with arbitrary values for an activity, which should theoretically result in 0 matching instances:

     "filter": {
       "hasIncidents": true,
       "activityFilters": [
         {
           "id": "1",
           "nodeId": "1",
           "name": "Ijustmadethisup",
           "status": "Pending"
         }
       ]
     }

2. Expectation: No workflow instances should be found due to the specified activityFilters.

3. Outcome: Despite the expectation, the plan is executed for the two instances.

Observed Behavior:

Upon reviewing the executed plan via {{elsaurl}}elsa/api/alterations/227522d98102f026, it's observed that the plan proceeded with alterations on both workflow instances that were supposed to be excluded by the filter.

"workflowInstanceFilter": {
  "hasIncidents": true,
  "activityFilters": [
    {
      "id": "1",
      "nodeId": "1",
      "name": "Ijustmadethisup",
      "status": "Pending"
    }
  ]
}

The status of both jobs is marked as "Completed", indicating that the filtering did not work as intended.

Expected Behavior:

The ActivityFilter should accurately filter out workflow instances that do not meet the specified criteria, in this case, not matching the arbitrary values specified for an activity.

Additional Context:

• This issue directly impacts the ability to selectively perform operations on workflow instances, potentially affecting performance and the accuracy of workflow alterations.
• Further investigation into how filters are applied and processed in the API might be necessary to identify the root cause of this discrepancy.