Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables passthrough of kubectl --context flag #4

Closed
wants to merge 1 commit into from
Closed

Enables passthrough of kubectl --context flag #4

wants to merge 1 commit into from

Conversation

deiga
Copy link

@deiga deiga commented Jan 31, 2020

No description provided.

@deiga deiga requested a review from elsesiy January 31, 2020 14:20
elsesiy
elsesiy requested changes Feb 2, 2020
View reviewed changes
Copy link
Owner

@elsesiy elsesiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This change seems incomplete to me, you're just adding a property to the internal struct but not using it anywhere in the actual process of retrieving the secret. Also you'd need to update the usage instructions accordingly

@deiga
Copy link
Author

deiga commented Feb 2, 2020

@elsesiy I tried to imitate how customNamespace is implemented. I can't find a place where that would be used either. But clearly something is missing as the tests are failing.

@elsesiy elsesiy mentioned this pull request Feb 5, 2020
Closed
@elsesiy
Copy link
Owner

elsesiy commented Feb 5, 2020

I fixed this in #6 and will create a release soon!

@elsesiy elsesiy closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsesiy elsesiy elsesiy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deiga @elsesiy