-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.16.4] Soul Enchanter can enchant tools that can't normally be enchanted #38
Comments
Is Tetra using the default enchantment tag to store modifiers? Eidolon definitely checks that the item is either:
I can see that Tetra modular tools return false for enchantable, and they clearly aren't books, so the only thing I can think of at the moment that would cause this is if Tetra puts its modifiers under the It's not immediately clear to me, then, if this should be fixed on Eidolon's or Tetra's side. I think the best solution would be for Tetra to simply use another tag, if the "enchantments" it uses aren't actually acquired by enchanting. But I can see from the code that that would be a fairly invasive change. I'll try and figure out a check I can do on my end. Merely checking |
Tetra most likely puts its modifiers under the Enchantments tag: They are enchantments, but they are applied by placing books within the tool, through the Tetra Workbench. We had a similar issue with the Industrial Foregoing Enchantment Extractor, the dev's solution was to blacklist items based on a tag, in this case called |
There's actually a really simple solution on Tetra's end, I think. There's a method If mickelus is unwilling to do this I can also make a tag, but I am currently in the midst of a larger content update so I can't say when I'd be able to release it. It's also a less robust solution in general, I think, so I'd prefer to avoid it. |
@mickelus There is a Tetra enchant compatibility issue, please read above :) |
I've got separate fields in the nbt tag for my modules & modifiers, when those change I populate the |
Describe the bug
I was able to enchant Tetra tools with the Soul Enchanter.
To Reproduce
Environment
Singleplayer
eidolon-0.2.7
The text was updated successfully, but these errors were encountered: