-
Notifications
You must be signed in to change notification settings - Fork 55
Support for SEP 10 challenge transaction #182
Comments
I am waiting for SEP-0010 v2.0 spec since there seem to be some disagreements on v1.0 implementation details. |
Not sure what you mean by "v2 spec"? Wording has been clarified with respect to the base64 cryptographic random string in stellar-protocol:#366. JS and Go implementations have been updated to reflect the intended behaviour: Go fix expected to merge to master for release by end of the week (Aug 10). So you should be good to go unless there are other concerns? |
In the issues under the spec it was labeled as such...
stellar/stellar-protocol#331
…On Thu, Aug 8, 2019 at 2:55 PM Eric Saunders ***@***.***> wrote:
Not sure what you mean by "v2 spec"? Wording has been clarified with
respect to the base64 cryptographic random string in stellar-protocol:#366
<stellar/stellar-protocol#366>.
JS and Go implementations have been updated to reflect the intended
behaviour:
JS: stellar/js-stellar-sdk#396
<stellar/js-stellar-sdk#396>
Go: stellar/go#1569 <stellar/go#1569>
Go fix expected to merge to master for release by end of the week (Aug 10).
So you should be good to go unless there are other concerns?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#182?email_source=notifications&email_token=AABVCUDFS6V7ZHTXPHHBUKDQDRT2RA5CNFSM4IJA5LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD34SPYI#issuecomment-519645153>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABVCUHHXA35VAXN3XX443LQDRT2RANCNFSM4IJA5LOQ>
.
|
Thanks for the link, that makes sense now. I asked for clarification internally at SDF. I'm told that these are future improvement ideas being recorded for reference. As far as I know there is no active drive to imminently replace the v1 spec. SEP 10 as it stands is being built out by a number of groups. I defer to you here: whether to implement sooner or wait for a while is of course your call. |
I gave the team the all is clear to implement this, but I did want to clarify. Thanks! |
SEP 10 describes a specific form for the "challenge" transaction used for authentication. Providing a helper at the SDK level makes sense to save users from reimplementing the spec.
Here are example implementations in Go and JS.
The text was updated successfully, but these errors were encountered: