Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a "net" module? #1104

Open
krader1961 opened this issue Aug 11, 2020 · 1 comment
Open

Introduce a "net" module? #1104

krader1961 opened this issue Aug 11, 2020 · 1 comment
Labels

Comments

@krader1961
Copy link
Contributor

Should there be a net module that includes a ifaddrs command? While improving test coverage I noticed the -ifaddrs experimental command in pkg/eval/builtin_fn_misc.go has no test coverage. As I write this here is the output I see on my primary MacPro server:

> -ifaddrs
▶ 127.0.0.1/8
▶ ::1/128
▶ fe80::1/64
▶ fe80::c3b:b807:bf46:17f7/64
▶ 2601:647:4600:7:1009:f734:4a3d:e7a1/64
▶ 192.168.1.102/24
▶ 2601:647:4600:7:d16e:87c0:e7c7:6a7a/64
▶ 2601:647:4600:7:6084:bf5:794e:5843/64
▶ 2601:647:4600:7:9590:6ca6:8d82:331b/64
▶ 2601:647:4600:7:8ca3:f48e:e026:9066/64
▶ 2601:647:4600:7:ad4b:b408:60c5:7b82/64
▶ 2601:647:4600:7:78cb:853c:7697:bf15/64
▶ 2601:647:4600:7:799c:3e75:1bae:8d5/64
▶ fe80::a4e5:6831:167f:5dc8/64
▶ fe80::f1f0:f68c:e83f:cded/64

It's not immediately obvious what purpose this command serves. The documentation says it should be part of a networking module; hence this issue. I think this command should be commented out until such time as it is moved to a net module and appropriate unit tests are written -- see issue #1062 about the need to improve test coverage.

@xiaq xiaq added the maybe label Feb 27, 2022
@krader1961
Copy link
Contributor Author

I am still perplexed why this experimental command exists. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants