Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform:elvish-path #1566

Merged
merged 2 commits into from Aug 13, 2022
Merged

Conversation

krader1961
Copy link
Contributor

Resolves #1423

@krader1961
Copy link
Contributor Author

In light of @xiaq's response to my solution for issue #1385, wherein they introduced a runtime module, I'm going to assume they would prefer this variable to exist in that namespace. Updated PR forthcoming...

@krader1961 krader1961 force-pushed the issue-1423-expose-elvish-path branch from 6ce7905 to 3239c38 Compare August 8, 2022 02:43
// This is read-only.

func elvishPath() any {
// TODO: Decide what to do if os.Executable returns an error. It appears that all platforms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern established here is to use $nil when there is any error.

@xiaq xiaq merged commit b040248 into elves:master Aug 13, 2022
@krader1961 krader1961 deleted the issue-1423-expose-elvish-path branch August 14, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the SHELL env variable to be the full path of the Elvish binary
2 participants