Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some external command dependencies #1680

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

krader1961
Copy link
Contributor

The epm module depends unnecessarily on several external commands; e.g., cat and test. Remove those dependencies. It also has a bug in its -first-upper function due to using the obsolete colon slice index syntax rather than the double period (..) syntax. Replace that function with the str:title builtin.

Related: 1661

The `epm` module depends unnecessarily on several external commands;
e.g., `cat` and `test`.  Remove those dependencies. It also has a bug in
its `-first-upper` function due to using the obsolete colon slice index
syntax rather than the double period (`..`) syntax. Replace that
function with the `str:title` builtin.

Related: 1661
@krader1961
Copy link
Contributor Author

@zzamboni, Please review this change.

@krader1961
Copy link
Contributor Author

Note that there are other possible improvements to the epm module. For example, when PR#1679 (#1679) is merged the sole use of the rm command can be replaced by path:remove. Similarly, I intend to introduce a path:mkdir command which will allow replacing the existing dependency on the external mkdir command with a builtin. Since the epm module has had few changes since it was added there are probably other improvements possible but those are outside the scope of this series of changes.

@xiaq xiaq merged commit 3dad55a into elves:master Apr 16, 2023
@krader1961 krader1961 deleted the issue-1661-epm-external-cmds branch April 17, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants