pkg/cli/tk/listbox_window.go: Fix divide by zero #1736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does fix the crash, but it means that when the available height is 1 all that is visible is the scrollbar, which isn't ideal. Better to show one row of actual content instead. I'm preparing that fix. |
xiaq
added a commit
that referenced
this pull request
Dec 31, 2023
Fix the division by 0, and special-case this condition to show one row of content and hide the scrollbar. This supersedes #1736.
|
I've implemented the fix I described so I'll close this PR. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
divide by zerowhen resizing terminal.Steps to reproduce:
related #1282