Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the str: module and add unit tests #928

Merged
merged 7 commits into from Mar 19, 2020

Conversation

krader1961
Copy link
Contributor

No description provided.

@krader1961 krader1961 changed the title Tiny step to documenting the str: module Document the str: module and add unit tests Mar 1, 2020
@krader1961 krader1961 mentioned this pull request Mar 6, 2020
pkg/eval/str/str.go Outdated Show resolved Hide resolved
pkg/eval/str/str.go Outdated Show resolved Hide resolved
pkg/eval/str/str.go Outdated Show resolved Hide resolved
pkg/eval/str/str.go Outdated Show resolved Hide resolved
pkg/eval/str/str.go Outdated Show resolved Hide resolved
pkg/eval/str/str_test.go Outdated Show resolved Hide resolved
@krader1961
Copy link
Contributor Author

@xiaq Please take another look.

Copy link
Member

@xiaq xiaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments on wording.

pkg/eval/str/str.go Outdated Show resolved Hide resolved
pkg/eval/str/str.go Outdated Show resolved Hide resolved
pkg/eval/str/str.go Outdated Show resolved Hide resolved
@xiaq xiaq merged commit 6d405cb into elves:master Mar 19, 2020
@krader1961 krader1961 deleted the document-str-module branch March 20, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants