fix: use span instead of div for icon #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elviswolcott could you please help me with the tests? I can not figure out why they do not pass. |
elviswolcott
approved these changes
Mar 25, 2020
| @@ -9,35 +9,31 @@ | |||
| <h1>This is a test</h1> | |||
| <div class="admonition admonition-note alert alert--secondary"> | |||
| <div class="admonition-heading"> | |||
| <h5> | |||
| <div class="admonition-icon">ℹ️</div>note</h5> | |||
| <h5><span class="admonition-icon">ℹ️</span>note</h5> | |||
There was a problem hiding this comment.
Because the tests are really flaky the difference in whitespace causes them to fail.
| <h5> | ||
| <div class="admonition-icon"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="14" height="16" viewBox="0 0 14 16"> | ||
| <h5><span class="admonition-icon"><svg xmlns="http://www.w3.org/2000/svg" width="14" height="16" viewBox="0 0 14 16"> |
There was a problem hiding this comment.
Same deal here with whitespace
|
Travis is refusing to even boot a VM for the branch build, but the PR is passing so I'll merge and release. |
|
1.2.1 is published 🎉 Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this audit facebook/docusaurus#2403
cc @elviswolcott