chore(v2): upgrade remark-admonitions for a11y fixes #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
Mar 29, 2020
| @@ -17,8 +17,7 @@ | |||
| "prism-react-renderer": "^1.0.2", | |||
| "prismjs": "^1.17.1", | |||
| "react-router-dom": "^5.1.2", | |||
| "react-toggle": "^4.1.1", | |||
| "remark-admonitions": "^1.2.0" | |||
There was a problem hiding this comment.
This is the redundant dep so I remove it.
|
Deploy preview for docusaurus-2 ready! Built with commit a5c2a2a |
yangshun
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refers to #2403
Resolve error of "Element “div” not allowed as child of element “h5” in this context. (Suppressing further errors from this subtree.)"
See elviswolcott/remark-admonitions#22
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Make sure that for icons in headings of admonitions instead of
divelement usedspan.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)