Network tile split related issues.

[2xsaiko]

Using Minecraft 1.12.1, Forge 14.22.0.2463, Teckle 1.12-5.378-SNAPSHOT.

Placed Sorting Machine, attached to some tubes and chests on either side to test. When I tried to load the world again, this happened: https://hastebin.com/ecorehaxan.md

[darkevilmac]

1.12.2? That doesn't exist as far as I know 🤔

Having trouble reproducing this. Any chance you can give some more detailed steps or an image?

[TheDeviantCrafter]

I can confirm the crash. Here's how it happened:

1. Loaded a singleplayer world
2. Spawned a sorting machine using JEI
3. Place the sorting machine on the ground. It was either facing east or west.

This crashed my client, with this crash log: https://hastebin.com/ajoyehajim.py

Loading back into the world gave me this crash: https://hastebin.com/ipovaxabaf.py

I was using 1.12.1, Forge 14.22.0.2462, teckle-1.12-5.363.jar

[darkevilmac]

363 is out of date. Test with 378 or greater.

…

On Aug 28, 2017 3:56 PM, "TheDeviantCrafter" ***@***.***> wrote: I can confirm the crash. Here's how it happened: 1. Loaded a singleplayer world 2. Spawned a sorting machine using JEI 3. Place the sorting machine on the ground. It was either facing east or west. This crashed my client, with this crash log: https://hastebin.com/ ajoyehajim.py Loading back into the world gave me this crash: https://hastebin.com/ ipovaxabaf.py I was using 1.12.1, Forge 14.22.0.2462, teckle-1.12-5.363.jar — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABusJG7vnEv3JGbi9EGSn9ZcuqTOO3Xuks5sc0WEgaJpZM4PEeBw> .

[2xsaiko]

Great. Now I can't reproduce it either, although I did the very same thing now. And yes, you're right, there's no 1.12.2. :P

[2xsaiko]

There's still definitely some weird stuff going on with saving and loading: https://youtu.be/hw6rIJH4dHs

[darkevilmac]

I'll look into the transport stuff but as I said before, items are invisible because it would be a pain to send so many packets on each client connecting.

[darkevilmac]

Leaving a note here for myself, working on the weird sorting machine bug and found the source. Not sure how I'm going to go about a fix quite yet.

ItemNetworkAssistant will call onNodePlaced during onNeighbourChange when it cant find a network tile. This is fine in some cases but it results in a sorting machine creating a secondary network when the node is destroyed. This causes a new network to be created that shouldn't exist and with no block to tell it to stop existing it simply stays in limbo, then when serialization is attempted there's an attempt to reference the network tile that doesn't exist which causes an error and eventually a crash.

[darkevilmac]

Copy of #21

Using Minecraft 1.12.2, Forge 14.22.0.2463, Teckle 1.12-5.378-SNAPSHOT.

When activating a transposer, it doesn't pull an "OH SHIT TECKLE BROKE" message appears in the log. The item might or might not get removed from the attached inventory.

Log: https://hastebin.com/ejabicapuw.md

[darkevilmac]

I made a bunch of changes in https://ci.elytradev.com/job/elytra/job/Teckle/job/1.12/94/

Please try this version and see if you still have any of these issues (or if anything else pops up)

[2xsaiko]

Using 5.385 from maven (should be the same as the one on CI?), after saving and loading, this exception occurs (which is similar to the first one I've encountered). Again, this only occurred once, I can't reproduce it again with a new world. Strange. Haven't encountered any other errors though.

[2xsaiko]

And there's another one, again on loading the world. This time it didn't crash the client entirely, just took all the items out of the attached chest and tubes https://hastebin.com/tazivicoxe.md (might or might not be related to my block, still testing)

And the transposer bug is kind of still there: this occurs because the transposer's bufferData is null (not always, though)

[darkevilmac]

Was the world that you loaded from the previous version? If so that would probably be why, I hadn't tested with an older world.

[darkevilmac]

I've made a few changes to fix bugs I've been finding myself.

Try the most recent builds and see if they work.

[darkevilmac]

Closing due to inactivity, if you find any more issues that haven't been mentioned here please open a new issue.