Explain, `why tramp-*-file-name-p' is a defsubst.

emacsmirror · Dec 14, 2012 · 8ffbfa2 · 8ffbfa2
1 parent 566faed
commit 8ffbfa2
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 0 deletions.
diff --git a/lisp/tramp-adb.el b/lisp/tramp-adb.el
@@ -111,6 +111,8 @@
     (start-file-process . tramp-adb-handle-start-file-process))
   "Alist of handler functions for Tramp ADB method.")
 
+;; It must be a `defsubst' in order to push the whole code into
+;; tramp-loaddefs.el.  Otherwise, there would be recursive autoloading.
 ;;;###tramp-autoload
 (defsubst tramp-adb-file-name-p (filename)
   "Check if it's a filename for ADB."

diff --git a/lisp/tramp-efs.el b/lisp/tramp-efs.el
@@ -209,6 +209,8 @@ pass to the OPERATION."
 ;; syntax (see defadvice of `efs-dired-before-readin' and
 ;; `efs-set-buffer-mode').  So a syntax check must be performed first;
 ;; otherwise `tramp-dissect-file-name' returns with an error.
+;; It must be a `defsubst' in order to push the whole code into
+;; tramp-loaddefs.el.  Otherwise, there would be recursive autoloading.
 ;;;###tramp-autoload
 (defsubst tramp-efs-file-name-p (filename)
   "Check if it's a filename that should be forwarded to EFS."

diff --git a/lisp/tramp-ftp.el b/lisp/tramp-ftp.el
@@ -200,6 +200,8 @@ pass to the OPERATION."
 		 (inhibit-file-name-operation operation))
 	    (apply 'ange-ftp-hook-function operation args)))))))
 
+;; It must be a `defsubst' in order to push the whole code into
+;; tramp-loaddefs.el.  Otherwise, there would be recursive autoloading.
 ;;;###tramp-autoload
 (defsubst tramp-ftp-file-name-p (filename)
   "Check if it's a filename that should be forwarded to Ange-FTP."

diff --git a/lisp/tramp-gvfs.el b/lisp/tramp-gvfs.el
@@ -432,6 +432,8 @@ Every entry is a list (NAME ADDRESS).")
   "Alist of handler functions for Tramp GVFS method.
 Operations not mentioned here will be handled by the default Emacs primitives.")
 
+;; It must be a `defsubst' in order to push the whole code into
+;; tramp-loaddefs.el.  Otherwise, there would be recursive autoloading.
 ;;;###tramp-autoload
 (defsubst tramp-gvfs-file-name-p (filename)
   "Check if it's a filename handled by the GVFS daemon."

diff --git a/lisp/tramp-smb.el b/lisp/tramp-smb.el
@@ -265,6 +265,8 @@ This can be used to disable echo etc."
   :type 'string
   :version "24.3")
 
+;; It must be a `defsubst' in order to push the whole code into
+;; tramp-loaddefs.el.  Otherwise, there would be recursive autoloading.
 ;;;###tramp-autoload
 (defsubst tramp-smb-file-name-p (filename)
   "Check if it's a filename for SMB servers."