Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in NetworkDispatcher #13

Closed
gerchicov-bp opened this issue Nov 25, 2019 · 1 comment
Closed

Bug in NetworkDispatcher #13

gerchicov-bp opened this issue Nov 25, 2019 · 1 comment

Comments

@gerchicov-bp
Copy link

gerchicov-bp commented Nov 25, 2019

return URLQueryItem(name: element.key, value: element.value as? String)
This allows to pass string params only. But if you replace element.value as? String with \(element.value) it will accept for example int and bool values too.

Additionally NetworkDispatcher is protected from inheritance and I should create a copy of it

@emadhegab
Copy link
Owner

emadhegab commented Nov 25, 2019

That's neither a but nor an issue.. Please refer to URLQueryItem you'll notice that value property must be an optional string . which make sense, since all query params treated usually as Strings not any primitive type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants