Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About priority #12

Closed
Kasualix opened this issue Jan 20, 2023 · 4 comments
Closed

About priority #12

Kasualix opened this issue Jan 20, 2023 · 4 comments

Comments

@Kasualix
Copy link
Contributor

Kasualix commented Jan 20, 2023

I saw this, but I just don't want to abandon this feature as my modpack always uses one trillion years to start jei when I enter my world.
Can I use "mixin.perf.async_jei=true" in modernfix-mixins.properties to override this?

Besides, I'm also a Modern UI user that can't leave it, but I have NEVER crashed with it (and with ModernFix since it first released at Jan 5, 2023) in my 300+ mods' modpack. My modpack don't have a need for strongholds and I have disabled them a long time ago so I can't tell anything with this. But A0000Xz is surely using a old version of Modern UI (here) and it must have bug(s). So I wonder if you could think about it again, should we really abandon "mixin.perf.async_jei" for an older version of Modern UI?

@embeddedt
Copy link
Owner

Can I use "mixin.perf.async_jei=true" in modernfix-mixins.properties to override this?

Yes, that should work.

So I wonder if you could think about it again, should we really abandon "mixin.perf.async_jei" for an older version of Modern UI?

Note that Modern UI causes other non-fatal problems too (such as the issue with JEI taking 4 minutes to start in the background due to how it forces tooltip processing to happen on the main thread). That issue can be worked around by turning off tooltip search in the JEI config but there are probably other issues I'm not aware of. This is why I opted to disable it by default.

@Kasualix
Copy link
Contributor Author

Modern UI can also disable its tooltip type in its config
image

@embeddedt
Copy link
Owner

If that option is disabled then you could probably re-enable async JEI without problems. But I would prefer to leave it disabled by default as experienced users would be more likely to know which configs to tweak.

@Kasualix
Copy link
Contributor Author

ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants