Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Numpy 2.0 #1263

Closed
mgraczyk opened this issue Sep 29, 2024 · 1 comment · Fixed by #1264
Closed

Allow Numpy 2.0 #1263

mgraczyk opened this issue Sep 29, 2024 · 1 comment · Fixed by #1264

Comments

@mgraczyk
Copy link
Contributor

mgraczyk commented Sep 29, 2024 •
edited
Loading

It looks like the issue blocking Numpy 2.0 has been closed:
via https://github.com/embeddings-benchmark/mteb/blob/main/pyproject.toml#L29
issue
huggingface/datasets#6980

Would it be possible to bump maximum allowed numpy version from <2 to <3 or <2.2?

I'm happy to create a PR and test if necessary
@isaac-chung
Copy link
Collaborator

I don't think there's anything more blocking us other than that issue. It would be great if you could create a PR @mgraczyk ! Looping in @KennethEnevoldsen as well.

@mgraczyk mgraczyk mentioned this issue Sep 29, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow Numpy >=2.0 Quilt-AI/mteb
2 participants
@mgraczyk @isaac-chung