Properly report exceptions #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 15, 2017
content-for/test-body-footer.html
Outdated
| return axe.run('#ember-testing-container', axe.ember.testOptions) | ||
| .then(axe.ember.a11yCheckCallback) | ||
| .catch(Ember.Test.adapter.exception) | ||
| .then(() => runningAudit = false); |
There was a problem hiding this comment.
axe-core only uses ES6 Promises, which don't have .finally (yet, it's in proposal)
There was a problem hiding this comment.
Gotcha! Thanks for double checking.
trentmwillis
force-pushed
the
handle-exceptions
branch
from
9f6dddc
to
09428a0
Compare
|
@ember-a11y/core, would appreciate another review. This should be the last one before releasing |
Robdel12
approved these changes
Feb 15, 2017
MelSumner
approved these changes
Feb 15, 2017
trentmwillis
force-pushed
the
handle-exceptions
branch
from
09428a0
to
341c9bf
Compare
|
Updated an existing test to verify the exception reporting behavior. Merging this now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since axe-core switched to using Promises internally, the exceptions during auto-run were getting swallowed. There is no correct way to hook into the Testing Promise system Ember uses, so we instead simply catch any errors and report them through the test adapter.
This will fix #47.