-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon.ico is not accessible at / #47
Comments
I guess broccoli-asset-rev does not fingerprint You can have a look at options for broccoli-asset-revs (the addon responsible for fingerprinting assets for a production build) here: https://github.com/rickharrison/broccoli-asset-rev#options After that it should be fine to upload your favicon to s3 and you can also update it, as it will be fingerprinted as any other asset. |
But would'nt it be better to let those assets be served by the main domain ? |
Well that depends what kind of deployment flow you are using. In my case the ember app would be the main domain. Sorry I thought you were having trouble with the fingerprint settings. If you want to exclude the ico file from the s3-upload you could just remove the file extension from the filePattern option for s3: https://github.com/ember-cli-deploy/ember-cli-deploy-s3#filepattern |
If I exclude *.ico files, ember will just route /favicon.ico to /public/favicon.ico ? |
Sorry, as you can see I'm a little lost here :-) |
Ember won't redirect a request for your favicon. The user's browser will just load the favicon based on what's the path for the favicon in the bootstrap index.html that ember-cli creates for you when running Hope that helps. |
You're right, indeed Ember has nothing to do with the routing of static ressources ! |
Hi,
How to prevent favicons and others from being uploaded to s3 ?
My goal is to have /favicon.ico accessible.
Config :
The text was updated successfully, but these errors were encountered: