Upgraded to Babel 7 beta #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's working with the latest beta now. The problem was that the imports were removed too early so the bindings were not available anymore later on. It was pretty much the same problem as described in babel/babel#7551 (comment) |
Turbo87
reviewed
Mar 20, 2018
package.json
Outdated
| "babel-register": "^6.22.0", | ||
| "@babel/core": "7.0.0-beta.42", | ||
| "@babel/preset-env": "7.0.0-beta.42", | ||
| "@babel/register": "7.0.0-beta.42", |
There was a problem hiding this comment.
do you think it would be possible to use something like https://github.com/joliss/node-multidep to test this with both Babel versions?
|
I've changed the tests to run on both Babel 6 and 7 now. Not sure if it is the most beautiful solution but it works 😅 |
|
Thank you for working on this @t-sauer, sorry for the delays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently doesn't work with the latest beta (40) but after a short discussion in the Babel Slack the problem looks like a bug in Babel and I think I've seen a PR a couple of days ago that should fix the problem (can't find it anymore though).