Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid assuming ember-template-compiler result is JSON #216

Merged
merged 1 commit into from
May 7, 2020
Merged

Avoid assuming ember-template-compiler result is JSON #216

merged 1 commit into from
May 7, 2020

Commits on May 7, 2020

  1. Avoid assuming ember-template-compiler result is JSON 

    It is fundamentally invalid to assume that
`require(emberTemplateCompilerPath).precompile('{{something}}')` returns
a `JSON.parse`able value.

New template features (strict mode, template imports, etc) will require
the precompiled template to actually be a function (older Ember versions
(prior to 2.10) also used functions).
    @rwjblue
    rwjblue committed May 7, 2020
    Configuration menu
    Copy the full SHA
    e273766 View commit details
    Browse the repository at this point in the history