Avoid assuming ember-template-compiler result is JSON #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is fundamentally invalid to assume that
`require(emberTemplateCompilerPath).precompile('{{something}}')` returns
a `JSON.parse`able value.
New template features (strict mode, template imports, etc) will require
the precompiled template to actually be a function (older Ember versions
(prior to 2.10) also used functions).
mmun
approved these changes
May 7, 2020
| function buildArrayExpression(array) { | ||
| return t.arrayExpression(array.map((i) => buildExpression(i))); | ||
| } | ||
| const parsePrecompiledTemplate = babel.template('PRECOMPILED'); |
chancancode
approved these changes
May 7, 2020
|
This should probably be notarized as a bug fix for older Embers. |
Ya, agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is fundamentally invalid to assume that
require(emberTemplateCompilerPath).precompile('{{something}}')returns aJSON.parseable value.New template features (strict mode, template imports, etc) will require the precompiled template to actually be a function (older Ember versions (prior to 2.10) also used functions).