Default ensureModuleApiPolyfill to true
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we released the refactor to transform to module names instead of the API polyfill, sometimes those modules would transform correctly, and sometimes they wouldn't. There appears to be a race condition between `babel-plugin-ember-modules-api-polyfill`, this plugin, and the AMD module transform. This PR updates the default for `ensureModuleApiPolyfill` to true to make sure we always transpile modules, and do not regress behavior.
rwjblue
deleted the
bugfix/make-ensure-modules-api-polyfill-default-to-true
branch
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we released the refactor to transform to module names instead of
the API polyfill, sometimes those modules would transform correctly,
and sometimes they wouldn't. There appears to be a race condition
between
babel-plugin-ember-modules-api-polyfill, this plugin, and theAMD module transform.
This PR updates the default for
ensureModuleApiPolyfillto true tomake sure we always transpile modules, and do not regress behavior.
Fixes emberjs/ember.js#19425