Upgrade broccoli-filter #14
Conversation
nickiaconis
force-pushed
the
filter-upgrade
branch
from
ea8dee3
to
65ff52a
Compare
|
@jonathanKingston I've reworked the tests so we can write different assertions for different filter input. I've also added that test I mentioned in #6 for using the relative config file. |
|
Can you rebase (I think latest work for publishing post-babel code caused merge conflicts)? |
nickiaconis
force-pushed
the
filter-upgrade
branch
5 times, most recently
from
1b21462
to
27069df
Compare
nickiaconis
force-pushed
the
filter-upgrade
branch
from
27069df
to
d1e1e30
Compare
|
Thanks for the ping. This should be able to merge again. |
Upgrade broccoli-filter
|
Fantastic! Btw, I noticed the TravisCI badge in the readme, but it seems Travis isn't turned on for this repo. You can turn it on if you'd like. Everything's currently passing: https://travis-ci.org/nickiaconis/broccoli-eslinter/builds/115141736 |
|
Odd must have deleted it, thanks @nickiaconis |
|
|
||
| this.cli = new CLIEngine(this.eslintOptions); | ||
|
|
||
| this.eslintrc = inputTree; |
There was a problem hiding this comment.
This seems to assume that inputTree is the srcDir string. Isn't inputTree an object? This breaks the paths in processString later on when we concatenate it to relativePath.
There was a problem hiding this comment.
@nickiaconis can this be addressed in #21? Pretty sure @teddyzeenny is right.
There was a problem hiding this comment.
Good point. All the tests provide a string as the input node, so I overlooked the possibility that this could be a tree instance. Any ideas how to resolve this from a tree? My first thought is to recursively resolve the _inputNodes objects until we get a string, but this doesn't account for merge trees.
Provides a solid basis for migrating to broccoli-persistent-filter.