Ensure custom templateCompilerPath is an absolute path. #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
ensure-template-path-is-absolute
branch
from
0fe7c74
to
730fb93
Compare
The examples that we show for using a custom template compiler path use a relative path, but that doesn't actually work when inline compilation runs and is parallelized (because the worker processes run from a different relative root inside `/tmp`). This ensures that any specified overrides are converted to absolute paths.
rwjblue
force-pushed
the
ensure-template-path-is-absolute
branch
from
730fb93
to
d13b5e2
Compare
mmun
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples that we show for using a custom template compiler path use a relative path, but that doesn't actually work when inline compilation runs and is parallelized (because the worker processes run from a different relative root inside
/tmp).This ensures that any specified overrides are converted to absolute paths.