Support Advanced Configuration #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support standard LiveReload options in a `liveReloadOptions` POJO in the `.ember-cli` file. This set of options is passed through to `window.LiveReloadOptions`. - Optionally override the absolute URL used to load `livereload.js` via a new `liveReloadJsUrl` option in the `.ember-cli` file.
|
Better late than never 😸 |
This was referenced Oct 20, 2016
| var liveReloadPort = process.env.EMBER_CLI_INJECT_LIVE_RELOAD_PORT; | ||
| dynamicScript: function(options) { | ||
| var liveReloadOptions = options.liveReloadOptions; | ||
| if (liveReloadOptions.snipver === undefined) { |
There was a problem hiding this comment.
it seems liveReloadOptions may be undefined at times: #35
This was referenced Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review and discussion...
As discussed in the
dev-ember-cliSlack channel, we made changes to support use of LiveReload through the reverse proxy in our development environment. Some additional complexity is due to the fact that we are using SSL locally.Support LiveReload option configuration
liveReloadOptionsPOJO inthe
.ember-clifile. This set of options is passed through towindow.LiveReloadOptions.livereload.jsviaa new
liveReloadJsUrloption in the.ember-clifile./cc @lukemelia