Let mocha float from 2.4.5 #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me! |
|
@Dhaulagiri Interesting to hear that |
|
It turned out that our custom reporter was blowing up in a weird way that caused this to happen with newer mocha. Since the reporter wasn't creating a lot of value we just removed it. I think this PR might still be nice for folks to give them the option to stay on the same version prior releases of ember-cli-mocha worked with, but it's not a blocker for us anymore. |
|
@Dhaulagiri my plan is to upgrade to Mocha 3.x soon anyway, so this will hopefully be irrelevant in the near future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the change in #124 to stop loading mocha from bower the version of mocha was changed from
~2.4.5to^2.5.3. For reasons that are not immediately obvious to me due to lack of time to dig in this breaks the test suite in one of our apps because mocha is not respecting.skipflags.I would still like to be able to use the latest changes in ember-cli-mocha though, so this PR changes the version of mocha specified in ember-cli-mocha to
^2.4.5. By default this will still give consumers of ember-cli-mocha version2.5.3of mocha, but it allows consumers of ember-cli-mocha to specify in their package.json version2.4.5to avoid any possible side effects of the bower -> npm change in this addon.